Do not forget to register DocumentIdScalar (#252)

* Register DocumentId * Add line to CHANGELOG.md
p2panda · Aug 22, 2022 · 0bf77f5 · 0bf77f5
1 parent 901748c
commit 0bf77f5
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -33,6 +33,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Filter out deleted documents in `get_documents_by_schema` SQL query [#193](https://github.com/p2panda/aquadoggo/pull/193)
 - Resolve implicit `__typename` field on dynamically generated GraphQL objects [#236](https://github.com/p2panda/aquadoggo/pull/236)
 - Allow `Content-Type` header [#236](https://github.com/p2panda/aquadoggo/pull/236)
+- Do not forget to register `DocumentIdScalar` [#252](https://github.com/p2panda/aquadoggo/pull/252)
 
 ## [0.3.0]
 

diff --git a/aquadoggo/src/graphql/client/dynamic_types/document_meta.rs b/aquadoggo/src/graphql/client/dynamic_types/document_meta.rs
@@ -37,7 +37,7 @@ impl DocumentMeta {
         );
 
         // Manually register scalar type in registry because it's not used in the static api.
-        DocumentViewIdScalar::create_type_info(registry);
+        DocumentIdScalar::create_type_info(registry);
 
         fields.insert(
             VIEW_ID_FIELD.to_string(),

diff --git a/aquadoggo/src/graphql/client/static_query.rs b/aquadoggo/src/graphql/client/static_query.rs
@@ -32,14 +32,6 @@ impl StaticQuery {
             can be left empty when it is a CREATE operation"
         )]
         document_view_id: Option<scalars::DocumentViewIdScalar>,
-        // @TODO: Figure out why this fixes things....
-        // Related issue: https://github.com/p2panda/aquadoggo/issues/242
-        #[graphql(
-            name = "documentId",
-            desc = "Document the entry's UPDATE or DELETE operation is referring to, \
-            can be left empty when it is a CREATE operation"
-        )]
-        _document_id: Option<scalars::DocumentIdScalar>,
     ) -> Result<NextArguments> {
         // Access the store from context.
         let store = ctx.data::<SqlStorage>()?;