Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Materializer crashes processing operations with pinned relations to non-existent views #178

Closed
sandreae opened this issue Jun 28, 2022 · 2 comments · Fixed by #177
Closed
Labels
bug Something isn't working

Comments

@sandreae
Copy link
Member

sandreae commented Jun 28, 2022

Test demonstrating the behaviour here: #177

@sandreae sandreae added the bug Something isn't working label Jun 28, 2022
@sandreae
Copy link
Member Author

Instead of returning Ok(None) here as we should (and are now) we were critically failing the task when a document disn't exist for the passed document view.

let document_id = match resolve_document_id(&context, &input).await? {
Some(document_id) => Ok(document_id),
None => {
debug!("No document found for this view, exit without dispatching any other tasks");
return Ok(None);
}
}?;

@sandreae
Copy link
Member Author

It's fixed in the above PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant