Fix bug when materialising documents containing (non-existent) pinned relations #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #177 +/- ##
==========================================
+ Coverage 90.53% 90.55% +0.01%
==========================================
Files 43 43
Lines 2885 2985 +100
==========================================
+ Hits 2612 2703 +91
- Misses 273 282 +9
Continue to review full report at Codecov.
|
sandreae
commented
Jun 28, 2022
Comment on lines
+25
to
+31
| let document_id = match resolve_document_id(&context, &input).await? { | ||
| Some(document_id) => Ok(document_id), | ||
| None => { | ||
| debug!("No document found for this view, exit without dispatching any other tasks"); | ||
| return Ok(None); | ||
| } | ||
| }?; |
There was a problem hiding this comment.
Instead of returning Ok(None) when a document for a requested view didn't exist, we were critically failing the task here.
Logic bug....
sandreae
changed the title
sandreae
changed the title
|
I think the test coverage drops here because all the |
adzialocha
approved these changes
Jun 29, 2022
adzialocha
added a commit
that referenced
this pull request
Jul 1, 2022
* main: Update CHANGELOG.md Refactor replication API (#184) GraphQL replication client (#137) Update aquadoggo to v0.3.0 in aquadoggo_cli v0.3.0 Prepare CHANGELOG for v0.3.0 release Commit Cargo.lock p2panda-rs v0.4.0 Remove unused import Update naming in `publishEntry` query and `nextEntryArgs` response (#181) Fix bug when materialising documents containing (non-existent) pinned relations (#177) Logging in reduce task (#175) Refactor test db creation (#176)
adzialocha
added a commit
that referenced
this pull request
Jul 1, 2022
* schema-provider: Minor clean ups Move to unreleased section in CHANGELOG Update CHANGELOG.md Refactor replication API (#184) GraphQL replication client (#137) Update aquadoggo to v0.3.0 in aquadoggo_cli v0.3.0 Prepare CHANGELOG for v0.3.0 release Commit Cargo.lock p2panda-rs v0.4.0 Remove unused import Update naming in `publishEntry` query and `nextEntryArgs` response (#181) Fix bug when materialising documents containing (non-existent) pinned relations (#177)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the materialiser comes across a pinned relations it kicks off a reduce task for each document view being related to. This is the correct behaviour. But then our clever reduce task was freaking out if there was no document for the requested document view already in the store. This is buggy behaviour. This PR fixes it by not critically failing the task but instead exiting the task silently. Also adds a test for this case.
branch includes unmerged changes from: #175 + #176
📋 Checklist
CHANGELOG.md