Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling "either or" field arguments in application schema GraphQL query #227

Open
cafca opened this issue Aug 7, 2022 · 6 comments
Open

Comments

@cafca
Copy link
Member

cafca commented Aug 7, 2022

According to our specification, the id and viewId field arguments are strictly "either or" and an error should be returned if both are given. Aquadoggo currently ignores the document id in this case.

We should either adapt the aquadoggo implementation or change the spec.

@cafca cafca mentioned this issue Aug 7, 2022
7 tasks
@adzialocha
Copy link
Member

As far as I know the tasks currently panic if they detect invalid task arguments. I've tried to find an either/or way to do types in Rust but couldn't find anything native, do you have an idea?

@cafca
Copy link
Member Author

cafca commented Aug 8, 2022

Oh, this is just about field arguments in the GraphQL api.

Wouldn't an enum work for tasks though?

@adzialocha adzialocha changed the title Handling "either or" field arguments Handling "either or" field arguments in GraphQL query Aug 8, 2022
@adzialocha
Copy link
Member

Oh, this is just about field arguments in the GraphQL api.

Oh lol, sorry, I've updated the issue title 👍

Wouldn't an enum work for tasks though?

Yeah, good point! I'm sure I've tried something and it didn't work out because of something else .. but worth another shot!

@adzialocha
Copy link
Member

https://www.youtube.com/watch?v=1PSVZGfhjWk

@cafca
Copy link
Member Author

cafca commented Aug 9, 2022

https://youtu.be/1PSVZGfhjWk?t=2035 ............ ???????

@adzialocha adzialocha changed the title Handling "either or" field arguments in GraphQL query Handling "either or" field arguments in application schema GraphQL query Aug 22, 2022
@adzialocha
Copy link
Member

From last meeting: We decided that it should be fine if they are both set, the node will go for the viewId then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants