New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic GraphQL document API #141

Merged

cafca merged 205 commits into main from graphql-document-query-experimental

Aug 7, 2022

Member

cafca commented Jun 1, 2022 •

edited

Loading

Main Course 🍲

Generates dynamic GraphQL schemas supporting introspection
Handles requests against these schemas

Side Dishes 🍚

Adds context field to TestDatabase
Adds add_document() and add_schema() helpers on TestDatabase

Depends on: #166 and p2panda/p2panda#416

Closing #64, #72, p2panda/p2panda#330

📋 Checklist

Add tests that cover your changes
Add this PR to the Unreleased section in CHANGELOG.md
Link this PR to any issues it closes
New files contain a SPDX license header
All spec changes reflected in handbook
- Updates for GraphQL api spec handbook#198
Merge Easy operations and schemas p2panda#416
Merge Implement new validation spec #204

Next

Compute complexity of queries to prevent expensive recursive queries
Add caching directives for fields that hit the database (debate?)
Cull outdated schemas from GraphQLManager and SchemaProvider #222
Handling "either or" field arguments in application schema GraphQL query #227

cafca added 30 commits

May 17, 2022 16:56


          Introduce client api with nextEntryArgs stub

b77460f


          Implement current nextEntryArgs RPC method using graphql

477aca4


          Fix basic graphql endpoint test

4bd6a18


          Add tests

9df6cd6


          Update changelog

599d0ca


          Handle errors

9b91ef8


          Clean up

591c6a0


          Refactor for storage provider

d0fc7c7


          Revert changelog style change

bdc9abe


          Move request/response structs to graphql client module

7eced50


          Adapt EntryArgsResponse implementation to GraphQL

58bcffb


          Recover old file structure for now

f935853


          Merge branch 'development' into graphql-client-api

0a309a8


          Improve test

a9ea7a1


          Switch back branch

89b3aeb


          Clarify test scope

821596a


          Handle serialisation in EntryArgsResponse impl


          Implement deserialisation

086c064


          Implement serialisation

1008b80


          Rearrange file

3fe7220


          Implement publishEntry mutation

9bf459f


          Add test for error handling

0a65d04


          Update changelog

660207a


          Merge branch 'development' into graphql-publish-entry

a74ed52


          Remove merge error

e4bb404


          Fix changelog format

b5850a7


          Adopt async-graphql naming

4b5beca


          Extend APi description

d2a6c67


          Remove renamed file

3656efd


          Experimental non-dynamic implementation

44cef4f

cafca added 10 commits

August 4, 2022 12:44


          Merge branch 'graphql-document-query-experimental' of github.com:p2pa…

cda6e1e

…nda/aquadoggo into graphql-document-query-experimental


          Replace quotation marks with explanation

f00c09d


          Remove StaticLeak

86d01e4


          Remove gql type name suffix

337271d


          ScalarType impl for scalars (WIP)

a858d44


          Safe ScalarType implementation of all scalar types

851dc1d


          Docstrings

8a3100e


          Don't answer queries for schemas that are not in the schema provider

328a2d6


          Add more debug output

02966ee


          Reduce nesting

980cd75

cafca mentioned this pull request

Analysis of validation in graphql api #224

Closed


          Remove aliases

07efded

Member

adzialocha commented Aug 4, 2022

Ah, I see now how Scalars work 👍 Soon you know so much about async graphql that you can make a PR and integrate dynamic schemas there 🤣🤩

cafca and others added 3 commits

August 4, 2022 17:40


          Use only one thread for tarpaulin

34dfb51


          Remove debug logging again

c27bb0d


          Merge branch 'main' into graphql-document-query-experimental

45beba6

Member

sandreae commented Aug 6, 2022 •

edited

Loading

~~FYI: I'm halfway merging main into this branch, just not quite finished yet.~~ done


          Make it work after merge

05c0ee0

sandreae requested a review from adzialocha

August 7, 2022 07:31

adzialocha approved these changes

View reviewed changes

Member

adzialocha left a comment

🌻🌻🌻🪐🪐🪐🌠🌠🌠

Member Author

cafca commented Aug 7, 2022

Amazing @sandreae! I'll have a final look now.

cafca added 3 commits

August 7, 2022 19:32


          Increase safety around dynamic schemas

96733d8

Use constants whenever possible for graphql field names etc.


          listing -> collection

873078b


          Fix debug log using Human

cdb1977

cafca merged commit 84c1b9b into main

Member

sandreae commented Aug 7, 2022

👏👏👏👏👏👏

Member

adzialocha commented Aug 7, 2022

Tadaaa!!!

Member Author

cafca commented Aug 8, 2022

I just realized that somewhere along the way the changelog update got overrun, have to add that back.

cafca mentioned this pull request

Detach add_document and add_schema from TestDatabase #237

Merged

4 tasks

adzialocha deleted the graphql-document-query-experimental branch

August 19, 2022 15:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment