Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure and rename modules #101

Merged
merged 6 commits into from
May 17, 2022
Merged

Restructure and rename modules #101

merged 6 commits into from
May 17, 2022

Conversation

sandreae
Copy link
Member

@sandreae sandreae commented May 9, 2022

  • restructure StorageProvider modules
  • remove JSON RPC completely
  • renaming
    • rename sql_store to provider
    • storage types (rows etc..) into models
    • the stores go into stores

馃搵 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@@ -23,6 +23,7 @@ bamboo-rs-core-ed25519-yasmf = "0.1.1"
crossbeam-queue = "0.3.5"
directories = "3.0.2"
envy = "0.4.2"
futures = "0.3.17"
hex = "0.4.3"
jsonrpc-v2 = { version = "0.10.1", features = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and maybe some other dependencies can go as well 馃憤

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandreae sandreae mentioned this pull request May 9, 2022
8 tasks
This was linked to issues May 10, 2022
@sandreae sandreae self-assigned this May 12, 2022
@cafca cafca mentioned this pull request May 17, 2022
Copy link
Member

@cafca cafca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rpc module still has some remnants that should be removed as a follow-up #121

@@ -23,6 +23,7 @@ bamboo-rs-core-ed25519-yasmf = "0.1.1"
crossbeam-queue = "0.3.5"
directories = "3.0.2"
envy = "0.4.2"
futures = "0.3.17"
hex = "0.4.3"
jsonrpc-v2 = { version = "0.10.1", features = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cafca cafca merged commit f875114 into development May 17, 2022
@cafca cafca deleted the restruct-modules branch May 17, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure modules Remove JSON RPC
3 participants