Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entry store updates review #123

Merged
merged 12 commits into from
May 17, 2022
Merged

Entry store updates review #123

merged 12 commits into from
May 17, 2022

Conversation

cafca
Copy link
Member

@cafca cafca commented May 17, 2022 •
edited

Describe your changes here.

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

cafca added 9 commits May 17, 2022 14:24
@cafca
Docstrings and typos
7143e6c
@cafca
Include failing value in fatal error message
4bdc61b
@cafca
Handle encoded u64 as NUMERIC
dec4619 
While SQLite cannot store u64 it can work with them, but only if they are cast as NUMERIC I think.

`SELECT CAST("18446744073709551610" as INTEGER) BETWEEN 18446744073709551609 AND 18446744073709551611;` => 0
`SELECT CAST("18446744073709551610" as NUMERIC) BETWEEN 18446744073709551609 AND 18446744073709551611;` => 1
@cafca
Rename test
e0958ac
@cafca
Format
860ed4f
@cafca
Clarification
bc4773b
@cafca
Create shorter import paths
69e8393
@cafca
Add comment on structure of db models vs traits
51ef659
@cafca
Update changelog
389a416
@cafca cafca marked this pull request as ready for review May 17, 2022 13:28
cafca
cafca commented May 17, 2022
View reviewed changes
aquadoggo/src/db/stores/log.rs Outdated Show resolved Hide resolved
@cafca cafca requested a review from sandreae May 17, 2022 13:28
sandreae
sandreae approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@sandreae sandreae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great, I would maybe just change the doc string for StorageLog as I don't htink we need to really explain the design decisions there.

@cafca cafca merged commit 0dcd81f into development May 17, 2022
@cafca cafca deleted the entry-store-updates-review branch May 17, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandreae sandreae sandreae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cafca @sandreae