Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI, track test coverage #139

Merged
merged 7 commits into from
May 31, 2022
Merged

Improve CI, track test coverage #139

merged 7 commits into from
May 31, 2022

Conversation

adzialocha
Copy link
Member

@adzialocha adzialocha commented May 30, 2022 •
edited
Loading

Add CodeCov, cargo clippy, cargo check and cargo fmt to our CI.

Closes: #140

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@codecov
Copy link

codecov bot commented May 30, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@fb6e7d7). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage        ?   92.26%           
=======================================
  Files           ?       16           
  Lines           ?      866           
  Branches        ?        0           
=======================================
  Hits            ?      799           
  Misses          ?       67           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb6e7d7...c565e99. Read the comment docs.

@adzialocha adzialocha linked an issue May 31, 2022 that may be closed by this pull request
CI: Use same pipeline as for p2panda_rs #140
Closed
@adzialocha adzialocha changed the title Improve CI Improve CI, track test coverage May 31, 2022
@adzialocha adzialocha marked this pull request as ready for review May 31, 2022 09:07
@adzialocha adzialocha marked this pull request as draft May 31, 2022 09:10
@adzialocha adzialocha linked an issue May 31, 2022 that may be closed by this pull request
CI: Tests should also run against PostgreSQL #31
Closed
@adzialocha adzialocha removed a link to an issue May 31, 2022
CI: Tests should also run against PostgreSQL #31
Closed
@adzialocha adzialocha marked this pull request as ready for review May 31, 2022 09:20
@adzialocha adzialocha requested review from sandreae and cafca May 31, 2022 09:21
sandreae
sandreae approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@sandreae sandreae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! I was missing our nice p2panda_rs CI. Thanks 🙏

This is going to main? Maybe we can merge it into development too at a good moment, we may still be working there for a little while.

@adzialocha
Copy link
Member Author

This is going to main? Maybe we can merge it into development too at a good moment, we may still be working there for a little while.

Yes, good idea!

@adzialocha adzialocha merged commit f9375b0 into main May 31, 2022
adzialocha added a commit that referenced this pull request May 31, 2022
@adzialocha
Merge branch 'main' into development
5842382 
* main:
  Improve CI, track test coverage (#139)
adzialocha added a commit that referenced this pull request May 31, 2022
@adzialocha
Merge branch 'development' into deduplicate-storage-provider
66f0822 
* development:
  Make clippy happy
  We can't drop a reference
  Fix merge conflict
  Doc strings for entry and log store structs (#126)
  Improve CI, track test coverage (#139)
  Fix high CPU usage of idle workers (#136)
adzialocha added a commit that referenced this pull request May 31, 2022
@adzialocha
Merge branch 'development' into schema-store
c7d6f5d 
* development:
  Make clippy happy
  We can't drop a reference
  Fix merge conflict
  Doc strings for entry and log store structs (#126)
  Improve CI, track test coverage (#139)
  Fix high CPU usage of idle workers (#136)
adzialocha added a commit that referenced this pull request May 31, 2022
@adzialocha
Merge branch 'development' into document-store
c23cf78 
* development:
  Make clippy happy
  We can't drop a reference
  Fix merge conflict
  Doc strings for entry and log store structs (#126)
  Improve CI, track test coverage (#139)
  Fix high CPU usage of idle workers (#136)
adzialocha added a commit that referenced this pull request May 31, 2022
@adzialocha
Merge branch 'development' into add-gql-replication-types
1e2c30a 
* development:
  Make clippy happy
  We can't drop a reference
  Fix merge conflict
  Doc strings for entry and log store structs (#126)
  Improve CI, track test coverage (#139)
  Fix high CPU usage of idle workers (#136)
  Define and implement `OperationStore` (#103)
@adzialocha adzialocha deleted the improve-ci branch June 11, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandreae sandreae sandreae approved these changes

@cafca cafca Awaiting requested review from cafca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Use same pipeline as for p2panda_rs
2 participants
@adzialocha @sandreae