Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update p2panda-rs API & refactor tests #147

Merged
merged 12 commits into from
Jun 8, 2022

Conversation

sandreae
Copy link
Member

@sandreae sandreae commented Jun 7, 2022

馃搵 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #147 (d662306) into development (5c604ef) will decrease coverage by 0.44%.
The diff coverage is 99.17%.

@@               Coverage Diff               @@
##           development     #147      +/-   ##
===============================================
- Coverage        94.22%   93.77%   -0.45%     
===============================================
  Files               28       28              
  Lines             1938     1847      -91     
===============================================
- Hits              1826     1732      -94     
- Misses             112      115       +3     
Impacted Files Coverage 螖
aquadoggo/src/db/stores/log.rs 97.97% <酶> (酶)
aquadoggo/src/db/stores/operation.rs 93.57% <95.91%> (-2.75%) 猬囷笍
aquadoggo/src/db/stores/document.rs 93.62% <100.00%> (-0.55%) 猬囷笍
aquadoggo/src/db/stores/entry.rs 94.87% <100.00%> (-0.48%) 猬囷笍
aquadoggo/src/db/stores/schema.rs 96.62% <100.00%> (-0.04%) 猬囷笍
aquadoggo/src/db/stores/test_utils.rs 99.03% <100.00%> (-0.13%) 猬囷笍
aquadoggo/src/db/utils.rs 99.52% <100.00%> (-0.01%) 猬囷笍
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 5c604ef...d662306. Read the comment docs.

@sandreae sandreae marked this pull request as ready for review June 7, 2022 10:56
@sandreae sandreae requested a review from adzialocha June 7, 2022 10:58
@sandreae
Copy link
Member Author

sandreae commented Jun 7, 2022

Again with the test cov... I can't see any lines that were covered before this PR and aren't now.

@sandreae sandreae changed the title Updates for p2panda-rs changes & refactor tests Update p2panda-rs API & refactor tests Jun 7, 2022
Copy link
Member

@adzialocha adzialocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just love this! 馃挅

#[future]
db: TestSqlStore,
) {
let db = db.await;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, wow.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this just wild?! 馃ぃ馃ぃ

@sandreae sandreae merged commit ec4db29 into development Jun 8, 2022
adzialocha added a commit that referenced this pull request Jun 20, 2022
* development: (42 commits)
  Implement `reduce` and `dependency` task logic (#144)
  Send published entries to materializer (#161)
  Updates for use of `VerifiedOperation` (#158)
  A backlink is not a skiplink (#163)
  Update README.md
  Remove clippy warnings
  Update `p2panda-rs` API & refactor tests (#147)
  fmt
  Rename `ES` generic type param to `EntryStore`
  Add better instructions for regenerating the schema file.
  Rename `skiplinks` to `certificate_pool` and regen schema
  Use cafca's wording for error message.
  Fix typo
  Target p2panda main (#142)
  Fix a clipp warn
  clippy --fix
  Add rt-multi-thread tokio feature to fix build of dump_schema
  Fix naming of param in SingleEntryAndPayload
  Add docstring to the `AliasedAuthor` type.
  Fix import order of tests
  ...
@adzialocha adzialocha deleted the changes-for-p2panda-updates branch June 29, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants