-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't error in SchemaStore when schema fields are missing #192
Conversation
Codecov Report
@@ Coverage Diff @@
## main #192 +/- ##
==========================================
- Coverage 93.62% 93.62% -0.01%
==========================================
Files 42 42
Lines 3155 3152 -3
==========================================
- Hits 2954 2951 -3
Misses 201 201
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you for fixing this!
I'd add some more comments on why certain things are the way there are, but otherwise its ready to go!
Currently we return an error from
get_schema
orget_all_schema
inSchemaStore
if a schema cannot be constructed due to it's fields not being present in the database. This isn't the behaviour we expect, rather we want to ignore any schemas which can't be fully constructed.馃搵 Checklist
CHANGELOG.md