Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test bug experiments #217

Closed

Conversation

sandreae
Copy link
Member

@sandreae sandreae commented Aug 1, 2022

Just trying some stuff out to test the ci

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@sandreae
Copy link
Member Author

sandreae commented Aug 1, 2022

This commit seems to be clearing up two of the test failures, doesn't really shed so much light on the actual problem, almost makes it more scary 🤣

@adzialocha
Copy link
Member

Hmn .. could it be that the http body gets somehow chopped up because the test ends too early? This is why we see "too short operation ids" or stuff like that? Just wondering ..

@sandreae
Copy link
Member Author

sandreae commented Aug 1, 2022

I wonder why the commit i made (extending the waiting times in the service test) fixes those bugs. That doesn't make sense so much to me.

@sandreae
Copy link
Member Author

sandreae commented Aug 1, 2022

Or is it just spawning the service for the first time takes a little time?

@cafca cafca changed the base branch from main to graphql-document-query-experimental August 1, 2022 11:27
@adzialocha
Copy link
Member

Looks like a good direction ✊

@cafca
Copy link
Member

cafca commented Aug 3, 2022

Closing in favour of #218

@cafca cafca closed this Aug 3, 2022
@adzialocha adzialocha deleted the test-bug-experiments branch August 19, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants