-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Friendly names for scalars in GraphQL schema #231
Conversation
@adzialocha the other odd one is |
Codecov Report
@@ Coverage Diff @@
## development #231 +/- ##
===============================================
+ Coverage 94.12% 94.24% +0.12%
===============================================
Files 59 59
Lines 4834 4867 +33
===============================================
+ Hits 4550 4587 +37
+ Misses 284 280 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adzialocha the other odd one is
EntryHash
as we just call thatHash
everywhere else. We could also rename it for consistency but on the other hand having a type just called "hash" might also be confusing. The type's description tells you what it is but still. What do you think?
I agree, let's stick to EntryHash
. Its also the only "Hash" we provide right now via the API.
Removes
Scalar
suffix in gql schema.Closes #229
馃搵 Checklist
CHANGELOG.md