-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage trait API changes #268
Conversation
p2panda_rs/#469
p2panda_rs/#469
Codecov ReportBase: 94.61% // Head: 94.17% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
==========================================
- Coverage 94.61% 94.17% -0.45%
==========================================
Files 59 61 +2
Lines 5108 5147 +39
==========================================
+ Hits 4833 4847 +14
- Misses 275 300 +25
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! After reading the API changes this was really easy to follow. I'm happy we're removing some fluff. Thank you!!
I haven't looked very closely at the tests but I trust that they are all still doing their job 😆
As always, only some formatting things and minor requests. With CHANGELOG.md entry this is ready to go.
Implement changes from p2panda/p2panda#469, refactoring (especially in
DocumentStore
) and a chance for better docs!StorageEntry
andEntryWithOperation
DocumentStore
which now returnsDocuments
from all getter methodsDocumentStore
trait anymore)document_id
column todocument_views
tableentry
log
operation
document
📋 Checklist
CHANGELOG.md