-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform "quick commit" in materializer service #280
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
==========================================
+ Coverage 92.46% 92.61% +0.14%
==========================================
Files 70 70
Lines 6573 6652 +79
==========================================
+ Hits 6078 6161 +83
+ Misses 495 491 -4
☔ View full report in Codecov by Sentry. |
This PR is still open, and I'm actually nervous to merge it, cos I think it will hide any concurrency bugs even deeper 😅 |
Oooh interesting, did you observe new / more issues on that branch? |
No new observations I'm afraid. Just the thought that by using "quick commits" to update documents without issuing reduce tasks, then we'd probably make reproducing any concurrency bugs even hard.... |
I think the errors I get are all happening before materialization (it's always about duplicate seq num, log id or some missing operation id hashes). Let me run this branch a couple of times and see if I can tell a difference in the issues. Would be nice to merge this! |
Same bugs as in #270, so all good 😆 |
Well, that's good..... lolz... |
I'll get this ready for merging when I have time then 👍 |
1107400
to
1a9d16d
Compare
Uses p2panda/p2panda#485 to perform a quick commit on a document instead of materializing from scratch.
📋 Checklist
CHANGELOG.md