Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Replication Service for now #296

Merged
merged 6 commits into from
Mar 16, 2023
Merged

Conversation

adzialocha
Copy link
Member

@adzialocha adzialocha commented Mar 16, 2023

Removes unused replication service and related test runner. These are all preparations for the upcoming work on a new replication protocol.

Closes: #297

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.03 🎉

Comparison is base (4267175) 91.39% compared to head (98438f6) 92.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
+ Coverage   91.39%   92.42%   +1.03%     
==========================================
  Files          54       51       -3     
  Lines        4054     3987      -67     
==========================================
- Hits         3705     3685      -20     
+ Misses        349      302      -47     
Impacted Files Coverage Δ
aquadoggo/src/config.rs 11.76% <ø> (-4.91%) ⬇️
aquadoggo/src/lib.rs 100.00% <ø> (ø)
aquadoggo/src/node.rs 84.61% <ø> (+1.85%) ⬆️
aquadoggo/src/test_utils/client.rs 88.57% <ø> (+9.08%) ⬆️
aquadoggo/src/test_utils/node.rs 100.00% <ø> (+2.98%) ⬆️
aquadoggo/src/test_utils/runner.rs 90.00% <ø> (+42.63%) ⬆️
aquadoggo/src/db/stores/entry.rs 96.26% <100.00%> (ø)
aquadoggo/src/db/types/entry.rs 88.57% <100.00%> (ø)
aquadoggo/src/graphql/mutations/publish.rs 100.00% <100.00%> (ø)
aquadoggo/src/network/config.rs 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adzialocha adzialocha marked this pull request as ready for review March 16, 2023 12:17
@adzialocha
Copy link
Member Author

I moved the remote_peers config field into NetworkConfiguration, hope that was alright @mycognosist? Another option is to move it into the Configuration root object of course.

@mycognosist
Copy link
Contributor

@adzialocha

Having it in NetworkConfiguration makes sense to me.

Copy link
Contributor

@mycognosist mycognosist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@adzialocha adzialocha merged commit 3265d4a into main Mar 16, 2023
@adzialocha adzialocha deleted the remove-replication-service branch March 16, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused replication service and test utilities
2 participants