-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify network CLI options and configuration #322
Conversation
Some aspects of |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
==========================================
+ Coverage 89.29% 89.36% +0.06%
==========================================
Files 68 68
Lines 5027 5029 +2
==========================================
+ Hits 4489 4494 +5
+ Misses 538 535 -3
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Currently working to address the deprecation warnings from Opened an issue here: libp2p/rust-libp2p#3791 |
Ready for review 🟢 🙏🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, very nice change of the API, let's merge it!
Addresses #319
Reduces the existing set of network-related CLI options:
To this:
Rendezvous client mode is enabled if
--rendezvous-address
is provided. The same is true for--relay-address
. These two options now include the peer's ID as part of the multiaddress.This PR also bumps
libp2p
version to0.51.3
and removes deprecated code:swarm::ConnectionLimits
with newconnection_limits::Behaviour
BannedPeer
SwarmEvent
quic
to use separate crate dependencySee https://github.com/libp2p/rust-libp2p/blob/master/libp2p/CHANGELOG.md#0512
📋 Checklist
CHANGELOG.md