Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize e2e GraphQL tests #342

Merged
merged 9 commits into from
Apr 25, 2023
Merged

Finalize e2e GraphQL tests #342

merged 9 commits into from
Apr 25, 2023

Conversation

adzialocha
Copy link
Member

@adzialocha adzialocha commented Apr 25, 2023

Brings back "dead" e2e tests and fixes an issue where using __typename in the query resulted in an empty response.

Closes #330

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.61 🎉

Comparison is base (784a0ef) 89.46% compared to head (6c12410) 90.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
+ Coverage   89.46%   90.07%   +0.61%     
==========================================
  Files          70       70              
  Lines        5998     6067      +69     
==========================================
+ Hits         5366     5465      +99     
+ Misses        632      602      -30     
Impacted Files Coverage Δ
aquadoggo/src/db/stores/query.rs 94.37% <ø> (+0.10%) ⬆️
aquadoggo/src/graphql/types/document_fields.rs 91.22% <ø> (+43.85%) ⬆️
aquadoggo/src/graphql/queries/document.rs 100.00% <100.00%> (ø)
aquadoggo/src/graphql/tests.rs 100.00% <100.00%> (ø)
aquadoggo/src/graphql/utils.rs 59.31% <100.00%> (+0.40%) ⬆️
aquadoggo/src/test_utils/node.rs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adzialocha adzialocha marked this pull request as ready for review April 25, 2023 17:24
@sandreae sandreae merged commit e6e8e31 into main Apr 25, 2023
8 checks passed
@sandreae sandreae deleted the finalize-graphql-tests branch April 25, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finalize e2e tests from query PRs
2 participants