-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move GraphQL types into separate modules #343
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
==========================================
+ Coverage 90.67% 90.68% +0.01%
==========================================
Files 74 74
Lines 6423 6423
==========================================
+ Hits 5824 5825 +1
+ Misses 599 598 -1
☔ View full report in Codecov by Sentry. |
During development of the low-level query backend I stumbled over not finding the methods which resolve certain parts of the GraphQL tree, so I thought it could be cool to move it all to a There are more resolvers of course (for example for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeh, looks good to me. Actually, my first design of these module builders/reducers was in a functional style like this, but I changed it along the way cos I thought it gave a familiar api between the dynamic and static types. I didn't really think it was a big success though. I like this 👍
Yeh, agree it's fine like this now. |
* main: Move GraphQL types into separate modules (#343)
This PR restructures the
graphql::types
module.DocumentValue
toResolved
and implementdowncast
method on itPaginationData
tostores::query
as it is not related to GraphQLall_documents
query tocollection
📋 Checklist
CHANGELOG.md
Link this PR to any issues it closes