Not so basic collection e2e tests #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
==========================================
+ Coverage 90.23% 92.40% +2.17%
==========================================
Files 70 70
Lines 6175 6520 +345
==========================================
+ Hits 5572 6025 +453
+ Misses 603 495 -108
☔ View full report in Codecov by Sentry. |
|
Hahaha, beautiful!!! 🙈❤️ |
sandreae
commented
Apr 28, 2023
sandreae
commented
Apr 28, 2023
sandreae
commented
Apr 28, 2023
Comment on lines
+813
to
+817
| // @TODO: fails due to syntax errors or unrecognized tokens in db, see: https://github.com/p2panda/aquadoggo/issues/349 | ||
| // #[case("(filter: { title: { notIn: [ \"Natural's Not In\" ] } })", "")] | ||
| // #[case("(filter: { title: { eq: \"Natural's Not In\" } })", "")] | ||
| // #[case("(filter: { title: { notEq: \"Natural's Not In\", in: [ \"Oh Bondage Up Yours!\", \"Speed Of Life\" ] } })", "")] | ||
| // #[case("(filter: { title: { notEq: \"Natural's Not In\" }, release_year: { gt: 1978 }, artist: { in: [ \"X-ray Spex\"] } })", "")] |
There was a problem hiding this comment.
Errors returned from database here because of recognised tokens
sandreae
commented
Apr 28, 2023
Comment on lines
+783
to
+787
| // @TODO: these fails, see: https://github.com/p2panda/aquadoggo/issues/353 | ||
| // #[case("(meta: { owner: { eq: \"2f8e50c2ede6d936ecc3144187ff1c273808185cfbc5ff3d3748d1ff7353fc96\" } })", "")] | ||
| // #[case("(meta: { owner: { notEq: \"2f8e50c2ede6d936ecc3144187ff1c273808185cfbc5ff3d3748d1ff7353fc96\" } })", "")] | ||
| // #[case("(meta: { owner: { in: [ \"2f8e50c2ede6d936ecc3144187ff1c273808185cfbc5ff3d3748d1ff7353fc96\" ] } })", "")] | ||
| // #[case("(meta: { owner: { notIn: [ \"2f8e50c2ede6d936ecc3144187ff1c273808185cfbc5ff3d3748d1ff7353fc96\" ] } })", "")] |
There was a problem hiding this comment.
Errors returned from database here because no owner field present.
sandreae
force-pushed
the
not-so-basic-collection-e2e-tests
branch
from
e864fd4
to
c91eb21
Compare
sandreae
commented
Apr 30, 2023
|
Wondering if we can split this up in multiple PRs? |
sandreae
force-pushed
the
not-so-basic-collection-e2e-tests
branch
from
c0f53a5
to
c91eb21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo
no such column: ownererror when filtering collection by owner #353Sanitise user inputs intended for sql queries #349un-comment failing testsSeparated this PR into multiple to deal with the other issues 👍
closes: #348 #350
📋 Checklist
CHANGELOG.md