-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replication protocol session manager #363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* sync-session: Update SessionManager to use new Session api Update Session Move traits into own module and implement Clone for Strategy Remove duplicate Mode structs Integrate strategies onto Session Implement Strategy trait for NaiveStrategy Define strategy trait Make StrategyMessage public Rename ScopedMessage -> StrategyMessage Introduce scoped message
* main: Do not pin versions anymore, fix changes Actually pin versions in Cargo.toml
4 tasks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## development #363 +/- ##
===============================================
- Coverage 92.39% 91.89% -0.51%
===============================================
Files 70 75 +5
Lines 6549 6710 +161
===============================================
+ Hits 6051 6166 +115
- Misses 498 544 +46
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of a manager handling sessions of the p2panda replication protocol as specified in https://p2panda.org/specification/replication/.
The manager makes sure that multiple replication sessions can be handled at the same time with different / same peers. It makes sure that no duplicate work is done and no dead locks occur when two peers initiate the same session at the same time.
On top it provides a pluggable interface for different replication "strategies", which we implement in separate PRs.
This implementation is agnostic of the underlying networking layer or async runtime. The glue to the aquadoggo libp2p networking stack is handled here: #365
Closes #372
Next Steps
📋 Checklist
CHANGELOG.md