Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replication message de- / serialization #375

Merged
merged 12 commits into from
May 16, 2023
Merged

Conversation

adzialocha
Copy link
Member

@adzialocha adzialocha commented May 15, 2023

Implement Serialize and Deserialize traits for the basic replication message types: SyncRequest, Entry and SyncDone.

Closes #374

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@adzialocha adzialocha changed the base branch from main to development May 15, 2023 11:54
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 76.53% and project coverage change: -0.39 ⚠️

Comparison is base (11744f7) 91.87% compared to head (ac031e1) 91.49%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #375      +/-   ##
===============================================
- Coverage        91.87%   91.49%   -0.39%     
===============================================
  Files               75       77       +2     
  Lines             6710     6855     +145     
===============================================
+ Hits              6165     6272     +107     
- Misses             545      583      +38     
Impacted Files Coverage Δ
aquadoggo/src/replication/message.rs 67.81% <67.81%> (ø)
aquadoggo/src/replication/mode.rs 70.58% <70.58%> (ø)
aquadoggo/src/replication/target_set.rs 90.90% <90.90%> (ø)
aquadoggo/src/replication/manager.rs 80.41% <100.00%> (-0.97%) ⬇️
aquadoggo/src/test_utils/helpers.rs 97.43% <100.00%> (+0.37%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adzialocha adzialocha linked an issue May 15, 2023 that may be closed by this pull request
@adzialocha adzialocha marked this pull request as ready for review May 15, 2023 16:32
@adzialocha adzialocha requested a review from sandreae May 15, 2023 16:32
Copy link
Member

@sandreae sandreae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@sandreae sandreae merged commit 0ab5072 into development May 16, 2023
@adzialocha adzialocha deleted the message-serialization branch May 16, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

De- / Serialize replication messages
2 participants