Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quick_commit from materialization service #450

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Conversation

sandreae
Copy link
Member

@sandreae sandreae commented Jul 14, 2023

This is a stop-gap solution to #448

Eventually we want to move quick_commit logic into the reduce tasks, but that takes a little bit more thought, and as it is only an optimisation in any case we can do without it for now.

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11 ⚠️

Comparison is base (1d52522) 89.95% compared to head (ff8cb79) 89.84%.

❗ Current head ff8cb79 differs from pull request most recent head 81b298c. Consider uploading reports for the commit 81b298c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
- Coverage   89.95%   89.84%   -0.11%     
==========================================
  Files          88       88              
  Lines        8886     8807      -79     
==========================================
- Hits         7993     7913      -80     
- Misses        893      894       +1     
Impacted Files Coverage Δ
aquadoggo/src/materializer/service.rs 95.52% <100.00%> (+0.16%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sandreae sandreae marked this pull request as ready for review July 14, 2023 15:28
@sandreae sandreae merged commit d9b196b into main Jul 14, 2023
6 of 7 checks passed
@adzialocha adzialocha deleted the revert-quick-commit branch July 18, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replication does not collect entries because sorted_index not set on quick_commit
1 participant