Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check affected rows when deleting task #461

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

sandreae
Copy link
Member

@sandreae sandreae commented Jul 25, 2023

closes: #458

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (25707ca) 91.82% compared to head (55c5d0b) 91.83%.

❗ Current head 55c5d0b differs from pull request most recent head 157f59d. Consider uploading reports for the commit 157f59d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
+ Coverage   91.82%   91.83%   +0.01%     
==========================================
  Files         100      100              
  Lines       15733    15731       -2     
==========================================
  Hits        14447    14447              
+ Misses       1286     1284       -2     
Files Changed Coverage Δ
aquadoggo/src/db/stores/task.rs 98.33% <100.00%> (+0.79%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandreae sandreae marked this pull request as ready for review July 25, 2023 17:51
@adzialocha adzialocha merged commit ecc2955 into main Jul 26, 2023
8 checks passed
@adzialocha adzialocha deleted the remove-affected-row-check branch July 26, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed removing completed task from database
2 participants