Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform peer sampling before initiating replication requests #463

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

sandreae
Copy link
Member

@sandreae sandreae commented Jul 26, 2023

Take a random sample of the available peers in the replication service and only initiate replication sessions with them.

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@sandreae sandreae linked an issue Jul 26, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (ecc2955) 91.84% compared to head (dfc6899) 91.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
- Coverage   91.84%   91.83%   -0.02%     
==========================================
  Files         100      100              
  Lines       15731    15733       +2     
==========================================
  Hits        14448    14448              
- Misses       1283     1285       +2     
Files Changed Coverage Δ
aquadoggo/src/replication/service.rs 75.21% <100.00%> (+0.21%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandreae sandreae marked this pull request as ready for review July 26, 2023 13:05
@sandreae sandreae requested a review from adzialocha July 26, 2023 21:54
@adzialocha adzialocha merged commit 27e84cd into main Jul 27, 2023
5 checks passed
@adzialocha adzialocha deleted the sample-replication-peers branch July 27, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Peer sampling in replication service
2 participants