Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce chatty warnings in network and replication services #467

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

sandreae
Copy link
Member

@sandreae sandreae commented Jul 26, 2023

  • don't warn! (just debug!) when a session wasn't found for a replication message, this has normally been followed by the actual error which closed the session
  • reduce most logging which we are bubbling up from libp2p in the network service to debug! (only warn! when it's a connection closure event that we are explicitly responding to in panda land)
  • don't warn when dial attempts fail, this is normally because there is an existing dial attempt in progress, it's not an actual connection error, these get picked up elsewhere.

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (ecc2955) 91.84% compared to head (38711ea) 91.82%.

❗ Current head 38711ea differs from pull request most recent head 4d38530. Consider uploading reports for the commit 4d38530 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
- Coverage   91.84%   91.82%   -0.02%     
==========================================
  Files         100      100              
  Lines       15731    15733       +2     
==========================================
- Hits        14448    14447       -1     
- Misses       1283     1286       +3     
Files Changed Coverage Δ
aquadoggo/src/network/service.rs 27.00% <0.00%> (ø)
aquadoggo/src/replication/manager.rs 87.69% <0.00%> (+0.12%) ⬆️
aquadoggo/src/replication/service.rs 74.36% <0.00%> (-0.64%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandreae
Copy link
Member Author

Some of these logs were. Really. Annoying.

@sandreae
Copy link
Member Author

We can also do a lot better than this, but it's an improvement at least.

@sandreae sandreae marked this pull request as ready for review July 26, 2023 18:18
@sandreae sandreae merged commit e656d80 into main Jul 26, 2023
8 checks passed
@adzialocha adzialocha deleted the slightly-better-logging branch July 27, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant