Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do nothing on log insertion conflict #468

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Conversation

sandreae
Copy link
Member

@sandreae sandreae commented Jul 26, 2023

closes: #462

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@sandreae sandreae marked this pull request as ready for review July 26, 2023 18:31
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (e656d80) 91.83% compared to head (c895df0) 91.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
- Coverage   91.83%   91.82%   -0.02%     
==========================================
  Files         100      100              
  Lines       15733    15734       +1     
==========================================
- Hits        14449    14447       -2     
- Misses       1284     1287       +3     
Files Changed Coverage Δ
aquadoggo/src/db/stores/log.rs 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandreae sandreae merged commit ec0e90e into main Jul 26, 2023
10 checks passed
@adzialocha adzialocha deleted the do-nothing-on-log-conflict branch July 27, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LogStore validation error during replication
1 participant