Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject SyncRequest containing unsupported TargetSet #469

Merged
merged 16 commits into from
Jul 27, 2023

Conversation

sandreae
Copy link
Member

@sandreae sandreae commented Jul 26, 2023

  • Accept list of schema ids in cli
  • Add supported_schema field to node config
  • Optionally set supported_schema on SchemaProvider which if set, is used to check schema added to the provider are supported
  • Only add supported schema to the GraphQL schema
  • Add dynamic_schema flag to node config if you want your node to dynamically support any schema (for programmatic use of aquadoggo not configurable via the cli)
  • Introduce IngestError::SchemaNotFound for when a schema wasn't materialized yet, but we do support it. This error is not elevated out of the replication manager and doesn't close the session or connection with the peer.

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 89.37% and project coverage change: +0.11% 🎉

Comparison is base (27e84cd) 91.83% compared to head (802a6a8) 91.94%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
+ Coverage   91.83%   91.94%   +0.11%     
==========================================
  Files         100      100              
  Lines       15736    15906     +170     
==========================================
+ Hits        14451    14625     +174     
+ Misses       1285     1281       -4     
Files Changed Coverage Δ
aquadoggo/src/replication/errors.rs 50.00% <ø> (ø)
aquadoggo/src/materializer/tasks/schema.rs 88.23% <66.66%> (-0.66%) ⬇️
aquadoggo/src/node.rs 84.72% <66.66%> (-4.35%) ⬇️
aquadoggo/src/replication/ingest.rs 94.66% <77.77%> (-2.40%) ⬇️
aquadoggo/src/schema/schema_provider.rs 89.61% <89.15%> (+0.13%) ⬆️
aquadoggo/src/replication/service.rs 84.82% <89.65%> (+10.24%) ⬆️
aquadoggo/src/config.rs 43.18% <100.00%> (+5.08%) ⬆️
aquadoggo/src/graphql/schema.rs 92.79% <100.00%> (+0.41%) ⬆️
aquadoggo/src/materializer/tasks/dependency.rs 97.53% <100.00%> (ø)
aquadoggo/src/replication/manager.rs 87.82% <100.00%> (+0.25%) ⬆️
... and 4 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandreae sandreae marked this pull request as ready for review July 27, 2023 15:45
@sandreae sandreae merged commit d7d3863 into main Jul 27, 2023
10 checks passed
@adzialocha adzialocha deleted the reject-not-matching-target-set branch July 27, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant