Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: only over-write http_port when cli arg is passed #489

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

sandreae
Copy link
Member

@sandreae sandreae commented Aug 7, 2023

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (d5ba55d) 91.95% compared to head (95034ff) 91.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
- Coverage   91.95%   91.94%   -0.02%     
==========================================
  Files         100      100              
  Lines       15914    15914              
==========================================
- Hits        14634    14632       -2     
- Misses       1280     1282       +2     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandreae sandreae merged commit 2d77668 into main Aug 7, 2023
10 checks passed
@sandreae sandreae deleted the fix-http-port-env-parsing branch August 9, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant