-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Announce supported schema ids in network before replication #515
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #515 +/- ##
==========================================
- Coverage 92.35% 92.16% -0.19%
==========================================
Files 99 101 +2
Lines 15801 16079 +278
==========================================
+ Hits 14593 14820 +227
- Misses 1208 1259 +51
☔ View full report in Codecov by Sentry. |
I don't feel like adding more tests to this, we have e2e tests checking against successful replication which still succeeded and I've extended our replication service "lifetime" test to deal with announcement messages. Think that should be sufficient? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a couple of comments, only about naming. Except for that, all looking really good!
…n and scheduler beat
13792fc
to
5dda823
Compare
* main: Announce supported schema ids in network before replication (#515)
This PR introduces our concept of "Announcements" (read more here: https://p2panda.org/specification/replication/#1-announcement).
There's a specification change involved: We need to give
Announce
messages their own message type. I've took0
for them and changed the ones forSyncRequest
,SyncDone
andEntry
as well. Related PR: p2panda/handbook#290Closes #405
📋 Checklist
CHANGELOG.md