Move deserialization into PeerMessage to distinct variants correctly
#538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adzialocha
changed the title
PeerMessage to distinct variants correctly
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
==========================================
- Coverage 92.20% 92.13% -0.07%
==========================================
Files 102 102
Lines 16108 16089 -19
==========================================
- Hits 14852 14824 -28
- Misses 1256 1265 +9
☔ View full report in Codecov by Sentry. |
sandreae
approved these changes
Aug 30, 2023
adzialocha
added a commit
that referenced
this pull request
Sep 6, 2023
* main: Minor README.md updates 0.5.0 Prepare README for v0.5.0 release (#532) Set unix cfg correctly Do only set permissions mode on unix Update RELEASE.md Improve log level user interface (#539) Move deserialization into `PeerMessage` to distinct variants correctly (#538) Bring back all connection handler logs to warn level again Add compiling windows binaries as well, remove macos universal one Adjust release profile Add checksum when releasing binaries Add v0.5.0 to CHANGELOG.md Add armv7-unknown-linux-gnueabihf target for cross compilation CI Add CI to compile and publish releases Make clippy happy Convert to ip addresses when logging multiaddr on info level Increase log level of handler errors to trace-level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where variants of
PeerMessagehave not been correctly determined during deserialization.📋 Checklist
CHANGELOG.mdLink this PR to any issues it closes