-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Garbage collect blobs from file system #571
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #571 +/- ##
==========================================
+ Coverage 92.43% 92.47% +0.03%
==========================================
Files 106 106
Lines 18164 18396 +232
==========================================
+ Hits 16790 17011 +221
- Misses 1374 1385 +11
☔ View full report in Codecov by Sentry. |
Very concise useful Postgres error in the CI: |
63a0027
to
970fc79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super cool to have gc for files! ✊🏻 Only a minor change request, otherwise ready to me
We already garbage collect unused blob views from the database, this PR implements garbage collecting blob views from the file system as well. This occurs both when a blob view is not the current view or pinned from another document, and for the current view as well when the blob document itself is not related to by any other document.
During implementation I did a little general renaming/refactoring in the garbage collection task to help code comprehension.
📋 Checklist
CHANGELOG.md