Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SocketAddr for all addresses in network config #576

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

sandreae
Copy link
Member

@sandreae sandreae commented Oct 11, 2023

Use SocketAddr everywhere in network config rather than MultiAddr.

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (94bc8e9) 92.48% compared to head (f8e62f1) 92.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
- Coverage   92.48%   92.46%   -0.02%     
==========================================
  Files         106      106              
  Lines       18396    18400       +4     
==========================================
+ Hits        17013    17014       +1     
- Misses       1383     1386       +3     
Files Coverage Δ
aquadoggo/src/network/config.rs 100.00% <ø> (ø)
aquadoggo/src/network/service.rs 30.42% <0.00%> (+0.38%) ⬆️
aquadoggo/src/network/utils.rs 60.86% <0.00%> (-32.47%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adzialocha adzialocha merged commit a24b2d8 into main Oct 11, 2023
10 checks passed
@adzialocha adzialocha deleted the use-socketaddr-in-network-config branch October 11, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants