Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: don't issue tasks for parent schema definition documents in schema task #581

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

sandreae
Copy link
Member

@sandreae sandreae commented Oct 13, 2023

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@sandreae sandreae marked this pull request as ready for review October 13, 2023 13:34
@sandreae sandreae linked an issue Oct 13, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (a24b2d8) 92.46% compared to head (8e72b5e) 92.69%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #581      +/-   ##
==========================================
+ Coverage   92.46%   92.69%   +0.23%     
==========================================
  Files         106      106              
  Lines       18400    18384      -16     
==========================================
+ Hits        17013    17041      +28     
+ Misses       1387     1343      -44     
Files Coverage Δ
aquadoggo/src/materializer/tasks/dependency.rs 97.39% <100.00%> (-0.14%) ⬇️
aquadoggo/src/materializer/tasks/schema.rs 96.26% <97.18%> (+8.03%) ⬆️
aquadoggo/src/materializer/tasks/blob.rs 84.25% <84.61%> (+28.05%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adzialocha adzialocha merged commit 4809fab into main Oct 13, 2023
10 checks passed
@adzialocha adzialocha deleted the fix-duplicate-schema-tasks-issued branch October 13, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

schema tasks issued too frequently
2 participants