Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log id selection #66

Merged
merged 7 commits into from
Feb 2, 2022
Merged

Fix log id selection #66

merged 7 commits into from
Feb 2, 2022

Conversation

cafca
Copy link
Member

@cafca cafca commented Feb 2, 2022 •
edited by adzialocha

  • Add test
  • Add unique constraint
  • Sort log IDs in memory as a temp solution

Closes #65

馃搵 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@cafca
Add test
1f011d9
@cafca
Add unique constraint
420c546 
Adding this to an old migration because we are pre v1. After all
everything can be justified by that. We should never go v1.
@cafca cafca mentioned this pull request Feb 2, 2022
Merged
5 tasks
@cafca cafca marked this pull request as ready for review February 2, 2022 18:22
@cafca cafca requested a review from adzialocha February 2, 2022 18:22
@adzialocha adzialocha merged commit c0c2885 into main Feb 2, 2022
@adzialocha adzialocha deleted the fix-log-id-selection branch February 2, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adzialocha adzialocha adzialocha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken next entry args implementation
2 participants
@cafca @adzialocha