Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL Database #9

Merged
merged 10 commits into from
Dec 11, 2020
Merged

SQL Database #9

merged 10 commits into from
Dec 11, 2020

Conversation

adzialocha
Copy link
Member

@adzialocha adzialocha commented Dec 7, 2020 •
edited

  • Agnostic SQL database backend via sqlx for PostgreSQL, MySQL and SQLite
  • Introduce DATABASE_URL and DATABASE_MAX_CONNECTIONS environment variables
  • Manage database via connection pool
  • Close connections on shutdown
  • Create / use SQLite database in data directory by default
  • Embedded database migrations when running application

@adzialocha adzialocha linked an issue Dec 7, 2020 that may be closed by this pull request
SQLite for persistence #2
Closed
@adzialocha adzialocha changed the title Database SQL Database Dec 7, 2020
cafca
cafca requested changes Dec 7, 2020
View reviewed changes
Copy link
Member

@cafca cafca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions - but seriously, please no odd number for the default port!

README.md Outdated Show resolved Hide resolved
core/src/config.rs Outdated Show resolved Hide resolved
db/src/utils.rs Show resolved Hide resolved
@adzialocha adzialocha requested a review from cafca December 8, 2020 14:55
cafca
cafca approved these changes Dec 8, 2020
View reviewed changes
README.md Show resolved Hide resolved
@p2panda p2panda locked and limited conversation to collaborators Dec 8, 2020
@p2panda p2panda unlocked this conversation Dec 8, 2020
@adzialocha adzialocha marked this pull request as ready for review December 8, 2020 18:30
@sophiiistika sophiiistika merged commit 06df4bb into main Dec 11, 2020
@sophiiistika sophiiistika deleted the database branch December 11, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cafca cafca cafca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQLite for persistence
3 participants
@adzialocha @cafca @sophiiistika