Use effective_value in Rust Bitcoin #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yancyribbens
force-pushed
the
feature/move-eff-value-to-rust-bitcoin
branch
from
376a6bf
to
ea56a21
Compare
|
@Tibo-lg maybe you care to comment on this or rust-bitcoin/rust-bitcoin#2230 |
|
It doesn't build for me locally: |
yancyribbens
force-pushed
the
feature/move-eff-value-to-rust-bitcoin
branch
from
ea56a21
to
096176e
Compare
Oops, I was asked to make this a stand-alone function instead of a method on TxOut. I updated this PR so it should work again now. |
Tibo-lg
reviewed
Dec 6, 2023
yancyribbens
force-pushed
the
feature/move-eff-value-to-rust-bitcoin
branch
from
f4e058f
to
5c6f24c
Compare
This PR removes the effective_value calculation instead prefering to outsource the calculation to Rust Bitcoin. Also, temporarily remove the error mod for now since Rust Bitcoin returns Option instead of Result.
Tibo-lg
reviewed
Dec 7, 2023
yancyribbens
force-pushed
the
feature/move-eff-value-to-rust-bitcoin
branch
from
5c6f24c
to
e2446b1
Compare
|
Merging for now since there seems to be no further feedback. Waiting on MR rust-bitcoin/rust-bitcoin#2230 to resolve. Will circle back and remove my fork of rust-bitcoin once resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the effective_value calculation instead preferring to outsource the calculation to Rust Bitcoin. Also, temporarily remove the error mod for now since Rust Bitcoin returns Option instead of Result. Leaving in Draft state until the outcome of rust-bitcoin/rust-bitcoin#2230 is decided.