Infinite scroll #4
Conversation
|
I think the warning is coming up because it's mixing the production version of create-react-class and the development version of react... |
src/Courses/Browse.jsx
Outdated
| @@ -8,8 +8,10 @@ class BrowseCourses extends React.Component { | |||
| } | |||
|
|
|||
| componentDidUpdate(prevProps) { | |||
| if (prevProps != this.props) { | |||
| $('[data-toggle="tooltip"]').tooltip(); | |||
| if (process.env.NODE_ENV === "production") { | |||
There was a problem hiding this comment.
Why do you need to check for production / development environment here?
There was a problem hiding this comment.
uh yeah, good point, that was just to get the demo working because i didn't have bootstrap and jquery loaded, but i added them and removed this check.
|
@s-kennedy thanks, I'll have a look. I remember before there was some difficulty in using webpack rather than rollup, Was it just an issue of configuring webpack, or did webpack add something new that makes it easier to build libraries? |
|
The infinite scroll works nicely, I had to change the |
I switched to webpack so I could set up the dev server and a demo page, that's not available in rollup. |
it' just hard coded in the constants, I updated that, thanks. |
The only issue I'm having is that I'm getting this warning on the P2PU website on the courses page whenever it fetches another set of results:
... but I don't the same warning with the demo in the package. It's coming from the common bundle. So I don't think it's from this package, but i'm not 100% sure.
Anyway @dirkcuys do you want to check this over before I merge it? I ditched rollup and went with webpack so we could have a dev server and a demo for development purposes.