Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Code of Conduct and Contributing.md file #11

Open
wants to merge 1 commit into
base: react
Choose a base branch
from

Conversation

Shaishav0507
Copy link

Hey @p32929
Check for the changes.
If you like them please update it.
Thanks

@p32929
Copy link
Owner

p32929 commented Jun 16, 2021

Good job. Thanks a lot. But I just have a small confusion.

Both files contain nearly 30-40 lines of texts individually. If these texts are this long, people might not even read it and after reading halfway through, people might lose interest to even contribute anything. Not that the contributions are a necessity for this project but still, people might get scared of the rules and might not even finish halfway of these rules and ignore the project completely...

Its just my opinion. I may be wrong. But I'm just worried...

@Shaishav0507
Copy link
Author

No I don't think so.
It would be for their benefit only as they would not get stuck somewhere.
Step by step guide will help them a lot.
And if any wants to contribute it would be great help for him.

@p32929
Copy link
Owner

p32929 commented Jun 16, 2021

Okay, just give me a few days. I need to show it some of my friends. Lets see, what they say about it. I'll ask them to write their opinions here.
If at least 50% people say that the number of lines in the files doesn't matter, I will accept the pull request.
& Still, I want to thank you for the amount of work you have done to make the pull request. I appreciate it...

@Shaishav0507
Copy link
Author

Ok sure.
Most welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants