Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error #12

Closed
wants to merge 1 commit into from
Closed

Conversation

maxgerhardt
Copy link

Worksaround platformio/platformio-core#4590, makes platform more robust
@maxgerhardt maxgerhardt marked this pull request as draft April 4, 2023 15:45
@p3p
Copy link
Owner

p3p commented Apr 4, 2023

Well this is a mess, releasing broken packages is not the best idea, thanks for bringing it to my attention I wouldn't have noticed for a while without clearing the caches and deleting the installed platform

@maxgerhardt
Copy link
Author

maxgerhardt commented Apr 4, 2023

I've converted this PR to a draft because I hope to get it fixed at the source, either by retraction or fixing of the broken GCC 11.x package -- though in any case it'd be better for the future to have the used compiler version either limited or fixed to a version.

So let's just wait for a bit more. It "just" affects people who've newly downloaded Marlin anyways, and the fix I posted in the community topic should unblock them for now.

@p3p
Copy link
Owner

p3p commented Apr 4, 2023

I'd rather not stop autoupdating the toolchain, but if we can't trust even a toolchain release you are probably correct that it should just use a specific version even if this is fixed upstream.

@maxgerhardt
Copy link
Author

Per https://registry.platformio.org/tools/platformio/toolchain-gccarmnoneeabi/versions the incomplete 11.x version has been removed from the registry (renamed to toolchain-gccarmnoneeabi-teensy) and thus compilation should be restored without any modifications.

So if auto-updating toolchains are still wanted, also no modifications need to be done here.

@maxgerhardt maxgerhardt closed this Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants