Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address the semantics of truncate #343

Merged
merged 1 commit into from
Aug 12, 2017
Merged

address the semantics of truncate #343

merged 1 commit into from
Aug 12, 2017

Conversation

cc10512
Copy link
Contributor

@cc10512 cc10512 commented Jul 3, 2017

Fixes #303.

@cc10512 cc10512 requested a review from jafingerhut July 3, 2017 04:19
mihaibudiu
mihaibudiu reviewed Aug 8, 2017
View reviewed changes
Copy link
Contributor

@mihaibudiu mihaibudiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if truncate is called several times with different arguments?

@jafingerhut jafingerhut merged commit b56648e into p4lang:master Aug 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaibudiu mihaibudiu mihaibudiu left review comments

@jafingerhut jafingerhut jafingerhut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cc10512 @jafingerhut @mihaibudiu