Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional statements in parsers #808

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Conditional statements in parsers #808

merged 2 commits into from
Jan 11, 2021

Conversation

mihaibudiu
Copy link
Contributor

No description provided.

@jafingerhut
Copy link
Collaborator

There is this phrase near the beginning of section 11 "Statements" that should be removed, too: "For example, conditionals are not supported in parsers"

Copy link
Collaborator

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I am not aware of any other modifications that would be needed to keep the spec internally consistent for this enhancement.

@mihaibudiu
Copy link
Contributor Author

mihaibudiu commented May 20, 2020

This is now implemented in the compiler, so we could even move it to 1.2.1 if we want.
p4lang/p4c#2386

@mihaibudiu mihaibudiu mentioned this pull request Nov 16, 2020
9 tasks
@mihaibudiu
Copy link
Contributor Author

The LDWG has decided to accept this change at the December 2020 meeting, so I am merging this into the spec.

@mihaibudiu mihaibudiu merged commit 208df2c into master Jan 11, 2021
@mihaibudiu mihaibudiu deleted the ifparser branch January 11, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants