Add XFAIL P4_14 test program that fails because of issue #1694 #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is nearly identical to the test program p414-special-ops.p4 proposed to be added in the PR p4lang#1704, except this program explicitly modifies metadata fields after a resubmit, recirculate, or clone operation is performed, and the STF tests will only pass if the behavior of the packet processing is that the metadata fields are preserved at the _end_ of ingress/egress processing, _not_ the values that the metadata fields have at the time of the recirculate/resubmit/clone primitive operation call. This is consistent with the P4_14 language specification, at least as of the clarifications made in v1.0.5 of the specification.
cc10512
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is nearly identical to the test program p414-special-ops.p4
proposed to be added in the PR #1704, except this program explicitly
modifies metadata fields after a resubmit, recirculate, or clone
operation is performed, and the STF tests will only pass if the
behavior of the packet processing is that the metadata fields are
preserved at the end of ingress/egress processing, not the values
that the metadata fields have at the time of the
recirculate/resubmit/clone primitive operation call.
This is consistent with the P4_14 language specification, at least as
of the clarifications made in v1.0.5 of the specification.