Add description of new value AUTO_DELETE for table property pna_idle_timeout #92
Conversation
Also clarify some wording in the description of add-on-miss, and remove the old signature in the document, in favor of using Madoko INCLUDE mechanism to include the corresponding section of the pna.p4 include file, so that the document and include file will remain in sync with each other.
| up and resulted in a miss, and the action name and action parameters | ||
| specified by the parameters of the call to the `add_entry` extern | ||
| function. Thus, future packets that invoke `t.apply()` with the same | ||
| lookup key will get a match and invoke the specified action (until and |
There was a problem hiding this comment.
Does this not assume in-order processing of packets across multiple flows? Should we not state this explicitly?
There was a problem hiding this comment.
I agree that there is a potentially subtle interaction here between pipelines that can have packets "pass each other up" in the middle of the pipeline, versus those that do not, and it would be good to address this issue somehow in the PNA spec. I will create a separate issue to track this, since I doubt I will quickly find an acceptable description, and that property of a packet processing pipeline probably affects other features besides this one.
There was a problem hiding this comment.
Created this issue: #96 Feel free to add comments on the topic there, but I hope it is reasonable to allow this PR to be merged before that issue is fully resolved.
|
LGTM. (It did leave me wondering whether the |
|
@thomascalvert-xlnx I like the idea of making AUTO_DELETE a new member of the enum PNA_IdleTimeout_t. I suppose some targets might even be able to implement a combination of notifying the control plane AND auto-deleting the entry when an entry expires, but no need to add that unless there is a request to do so. I will go ahead and change this PR with this idea, and see what others reviewers think. |
Instead, define a new value AUTO_DELETE for table property pna_idle_timeout.
jfingerh
changed the title
There was a problem hiding this comment.
Yes I like the AUTO_DELETE option, it looks cleaner IMHO.
Suggest that the text talks about how entries can be explicitly deleted (not via timeout but on seeing e.g. a RST packet), and briefly describe the semantics of ExpireTimeProfileId_t. But that could easily be added in a separate change to this one.
|
LGTM |
Also clarify some wording in the description of add-on-miss, and remove the old signature in the document, in favor of using Madoko INCLUDE mechanism to include the corresponding section of the pna.p4 include file, so that the document and include file will remain in sync with each other.