Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup.cfg format issue to match old setuptools versions. #197

Closed
wants to merge 1 commit into from

Conversation

liushilongbuaa
Copy link

@liushilongbuaa liushilongbuaa commented Jun 19, 2023

install_requires = file: requirements.txt

This kind of format will break old setuptools versions.
Currently requirements.txt is empty. Maybe it's better to remove this line temporarily.

@onf-cla-manager
Copy link

onf-cla-manager bot commented Jun 19, 2023

Hi @liushilongbuaa, this is the ONF bot 🤖 I'm glad you want to contribute to our projects! However, before accepting your contribution, we need to ask you to sign a Contributor License Agreement (CLA). You can do it online, it will take only a few minutes:

✒️ 👉 https://cla.opennetworking.org

After signing, make sure to add your Github user ID liushilongbuaa to the agreement.

For more information or help:"
https://wiki.opennetworking.org/x/BgCUI

@antoninbas
Copy link
Member

Why did you open a new PR and why are you no longer removing requirements.txt?
(it's also still asking you to sign the ONF CLA)

@antoninbas
Copy link
Member

@liushilongbuaa please accept the ONF CLA and address review comments, so we can move forward with this
otherwise, we will need to open a replacement PR so we can fix the issue

@antoninbas
Copy link
Member

@liushilongbuaa Thanks for bringing this to our attention and for the PR. We merged an alternative PR to this one (#199) in order to get a fix in faster, since we haven't heard from you in a couple of days.

@antoninbas antoninbas closed this Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants