New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change p5 dependency version to minimum 1.4.1 #318
Comments
What specifically is 1.9 missing that you need from 1.4? The main point is security updates, lowering the version would open the package and consumers of the package up to CVEs which are patched in the latest versions. |
Makes total sense. There are a couple bugs in the current p5 version that you can see here and here, which they've flagged. As a temporary fix since I'm working on a time-sensitive project that depends on that update, I was hoping to revert back to an older version of p5... but I'm unable to do that too 😅 Hence my request. |
I see your comments in those threads, indeed these are issues but do the workarounds suggested such as pixel density not work for your needs? If not, I'll consider making p5 a peer dependency but that would entail a new major release since it would disrupt existing user installs and also the other aforementioned topics would need documented and so on too. |
I appreciate that, and I wouldn't be asking if I didn't try a dozen other things first, including all of their workaround suggestions and then some. Totally understand treating it as a major release. Thought I'd try! |
Give me this evening (it's 8pm in Germany right now) to think about it, you'll know my decision by the morning (German time) 😜 CC @yevdyko |
omg💖 |
@jamesrweb I left some suggestions in the Discussions thread on how to avoid using a peer dependency |
Version 4.3.3 is now released and you should be able to request that version of p5 now @taliacotton. Let us know if it works for you or not and we can either close this issue or work on a fix then. CC @yevdyko |
Closing issue due to inactivity, @taliacotton - please comment here again if you have any issues with the latest deployed version and I can reopen this issue again. Otherwise I hope your problem is solved and good luck with your project 🍀😊 |
Discussed in #317
Originally posted by taliacotton February 15, 2024
I've noticed the component depends on a specific version of p5 (as of right now I see 1.9.0). I was wondering if there's a way to control which version of p5 it uses. The reason for this is that there are certain features of p5 in prior versions, so I'm wondering if it's possible to downgrade the version. Thanks!
The text was updated successfully, but these errors were encountered: