Skip to content

Conversation

@yevdyko
Copy link
Contributor

@yevdyko yevdyko commented Feb 16, 2024

Fixes #328

This PR allows p5 versions in dependencies ranging from 1.4.1 to the latest one.

@yevdyko yevdyko self-assigned this Feb 16, 2024
jamesrweb
jamesrweb previously approved these changes Feb 17, 2024
@jamesrweb
Copy link
Member

You'll need to run pnpm install to update the lock file, that's why CI is failing currently @yevdyko

@yevdyko yevdyko force-pushed the allow-p5-versions-in-range branch from dde4986 to a13a927 Compare February 17, 2024 10:25
@yevdyko
Copy link
Contributor Author

yevdyko commented Feb 17, 2024

@jamesrweb  Done. It might be worth excluding the pnpm-lock file from the format check, since we keep trying to convert the auto-generated file to the different type of used quotes

@jamesrweb jamesrweb merged commit e899e89 into P5-wrapper:master Feb 17, 2024
@jamesrweb jamesrweb linked an issue Feb 19, 2024 that may be closed by this pull request
@yevdyko yevdyko deleted the allow-p5-versions-in-range branch February 28, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change p5 dependency version to minimum 1.4.1

2 participants