Module not found: Can't resolve 'p5'

[ghost]

Module not found: Can't resolve 'p5' in '..\node_modules\react-p5-wrapper\dist'

What am I doing wrong?

[manuquentin]

Hi @hellobetkowski, how did you manage to solve this issue ?

Thanks !

[mikejw]

bump!

[juanigaray]

Bumpt

[eoNicholls]

For anyone else who comes across this issue: I fixed it by running npm install p5

Apparently it's a separate dependency and has to be installed yourself.

[ShawKai91]

that didn't fix it for me

[jamesrweb]

Hi @ShawKai91, can you show the error you are getting as this shouldn't be an issue anymore since the last release anyway?

[ShawKai91]

On Thu, Dec 10, 2020 at 21:03 James Robb ***@***.***> wrote: Hi @ShawKai91 <https://github.com/ShawKai91>, can you show the error you are getting as this shouldn't be an issue anymore since the last release anyway? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#39 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APZUCJS25FFZA646YSJVVJTSUGKZNANCNFSM4JYFPY3Q> .

I was trying to use the var requires Instead of import

[ShawKai91]

On Thu, Dec 10, 2020 at 21:13 Kyle Shaw ***@***.***> wrote: On Thu, Dec 10, 2020 at 21:03 James Robb ***@***.***> wrote: > Hi @ShawKai91 <https://github.com/ShawKai91>, can you show the error you > are getting as this shouldn't be an issue anymore since the last release > anyway? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#39 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/APZUCJS25FFZA646YSJVVJTSUGKZNANCNFSM4JYFPY3Q> > . > I was trying to use the var requires Instead of import

I ended up getting it to work

…

[jamesrweb]

@ShawKai91 great, glad to hear that 😄

[yevdyko]

@jamesrweb I wonder if you're going to publish the fix to the npm and yarn packages. The last version is dated August 15, 2020. Any plans?

[jamesrweb]

@yevdyko I have NPM access to the repo but no-one has tested the fix from the master branch since @and-who doesn't have time to work on things personally and it's basically just me and so if you want to test and let me know or contribute, I'd be very happy.

[yevdyko]

Hey @jamesrweb, I created a demo app to see if the latest changes work as expected.

Here is the link: React P5 Wrapper Demo

As a result, everything works fine. So I think you can publish a new version. Please double-check my demo if needed. Thanks!

[jamesrweb]

@yevdyko thanks for checking, LGTM. I also merged #77 to be included in the next release.

[jamesrweb]

Version 2.4.0 is now on NPM @yevdyko, can you test with the new version?

[yevdyko]

@jamesrweb Looks good and works like a charm. Thanks for the quick release! 🙌