recognize core booleans in is_bool() #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenetheridge
force-pushed
the
ether/core-bools
branch
3 times, most recently
from
609baa9
to
8fb6ded
Compare
|
A concern here is that depending on the version of Cpanel::JSON::XS, is_bool may return true for a value that does not get encoded as a boolean. |
|
Yes. I noted that in the Changes entry. Force-requiring the latest version is probably too much though? Maybe not if combined with a perl version check. |
karenetheridge
force-pushed
the
ether/core-bools
branch
from
8fb6ded
to
b1be1e6
Compare
|
I bumped the minimum Cpanel::JSON::XS version on perls that have |
karenetheridge
force-pushed
the
ether/core-bools
branch
from
a54b303
to
7b57852
Compare
karenetheridge
force-pushed
the
ether/core-bools
branch
from
7b57852
to
7cc4b85
Compare
|
Hi! Just thought you should know that these two tests are failing for Perl 5.34: d71ee63#diff-3d48725130685ec3a9f564d8ee75b7a15d869fc2751d652803a593804b73e806R39-R40 I presume they should be moved up to the prior SKIP block. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.