Binded variables

[andreipet]

Hello.
Can we have an option to log bind variables (even without their names, just as an array).
As a fail safe mechanism to replace manually if necessary.
I currently log both the sql and the effectiveSql and i would like the variables as well.
10x.

[gavlyukovskiy]

Hi @andreipet do you mean binded variables like :name from Hibernate/Spring JDBC/Spring Data/JDBI? It's for sure impossible to get their names, but they should be there in effectiveSql, don't you have them?

[andreipet]

By binded I mean the replacements done in the prepared statement.
select * from table where name = ? and category = ?
I would like to log [(0 = "andrew"), (1 = "test")] when I set the prepared statement params: "andrew" and "test",
By the way, only once (in 6 months) something was terrible wrong and the effective sql where scrambled.
After an tomcat restart everything was fine (the replacements in effectiveSql were fine again).
Ty.

[gavlyukovskiy]

From code that replaces parameters I see that it actually doesn't skip comments, so if you have ? inside comment then this one will be replaced with actual value and all next values will be shifted. Do you remember if it was your case?

[andreipet]

When I saw the scrambling, I suspected that and removed the ? from a comment and redeployed. But it did not work. After restart it was fine again. Any way... it was scrambled once in 100000 times....but as a silver bullet I want to be able to log plain prepared parameter values (not the effective sql).

[typekpb]

Any volunteer for providing the solution for the comment replacement of ? ? Would be happy to see it solved

[gavlyukovskiy]

@typekpb I looked at it, but it's quite hard to implement. Currently parameters are returned from ResultSetInformation#getSqlWithValues which is little bit strange. Only way to implement it right is to change interaction between Loggable and P6LogQuery.
I can put some work on it, but I'm not sure if I can get it done quick due to lack of time currently.