Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResultSetInformation.getSqlWithValues() should return statementInformation.getSqlWithValues() but not resultMap #493

Closed
auntyellow opened this issue Feb 18, 2020 · 2 comments · Fixed by #503

Comments

@auntyellow
Copy link
Contributor

auntyellow commented Feb 18, 2020

This method now return the string of resultMap and confuses users.

May add something like getResultMap() to show results.

@auntyellow
Copy link
Contributor Author

Sorry, this issue is already mentioned in #467

@gavlyukovskiy
Copy link
Member

@auntyellow yes, it's a bit strange now and I'm afraid we cannot change it without breaking the logging. Out MessageFormattingStrategy uses this getSqlWithValues() to resolve %(effectiveSql) placeholder for both statements and result sets.

But I think adding getResultMap() would be nice to have so you can access it from listeners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants